-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/17/12 02:55, Ilya Yanok wrote: > Hi Joe, > > On Thu, Aug 30, 2012 at 1:25 AM, Joe Hershberger > <joe.hershber...@gmail.com <mailto:joe.hershber...@gmail.com>> > wrote: [snip] >> diff --git a/net/net.c b/net/net.c index e8ff066..bbd1a6d 100644 >> --- a/net/net.c +++ b/net/net.c @@ -81,6 +81,19 @@ >> >> >> #include <common.h> +#ifdef CONFIG_SPL_BUILD +/* SPL needs only >> BOOTP + TFTP so undefine other stuff to save > space */ >> +#undef CONFIG_CMD_DHCP +#undef CONFIG_CMD_CDP +#undef >> CONFIG_CMD_DNS +#undef CONFIG_CMD_LINK_LOCAL +#undef >> CONFIG_CMD_NFS +#undef CONFIG_CMD_PING +#undef CONFIG_CMD_RARP >> +#undef CONFIG_CMD_SNTP +#undef CONFIG_CMD_TFTPPUT +#undef >> CONFIG_CMD_TFTPSRV +#endif > > Is this the best place to do this? Seems it would be clearer to > modify config_cmd_default.h or add a config_cmd_spl.h that will > undefine them, and include that. > > > I agree it's not the best place... config_cmd_spl.h sounds a little > bit crazy as we don't have any commands at all in SPL...
How about config_uncmd_spl.h then and a nice big comment up top explaining what we're doing. Or can we take another stab at seeing why some stuff isn't being garbage collected? If garbage_collected_func_a calls never_seen_while_linking_func, we still succeed since we garbage collect the first func. There's just the gcc issue I've noted before about strings. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIcBAEBAgAGBQJQV1goAAoJENk4IS6UOR1WmCIQAKmnvVA5ZiYmWNqTvXPtjCz3 DRBfE8iLLpDzMgzjgEyy/3e3at7zE4+svN5ncYvkxPRBqiBol9InXYnUBdgZXiMk 7/HahZdJpsX1KwFGQxUTuRErABQXT14IQn0Nz/7xKbpHcFlrJSxPaKb3RblwBylj nZiRYhNfCFVzsMvmLPRk/IiHh9EMqwGDmKW1sAsF7qGw1CFzOTkLW9KKIqW6anUH JXOy0fVeVOyBK6erK2R0kFYbYSvpYUJPG88pymu/hiSHvwI2vOZdJ0g6Q9O3RKP3 rXz5Xnei5ujnQ5Kb8T5gES5Y1My/m1LXCqSY2Aq0cuyDnUEDItZLYycPKkrXZ3yf W73ydbMrT1BpFasWB/Crce/J54zIpLMnQiFpJ0vgv4sSD+yzrD4o02TsYeXgvekJ KpJRhsdRp1r190s2wdyeJTTSsP2yQCbPWGL/vDQr9hb1tdLK+EIxLsG++9uZxHQ5 TgtaPyvlScaz/WC0TxE3NRNOGFRqvTGa+MgD3JHoUOMfc1FhsZXIjoW5K239GvkL lIEFKYaTsFvo1lygPFUTZPEls4ElbeJ6OJjJy9xUs33avlpvTbkEqgkb2L39+uQM cK5LoGKqwyrEa8CMxyCkzD6GTywkf+LYiUmKY6Ped2svN0WRgakISOuDRXdAdsB0 W2Gx6XbRea/1iE+wHEUC =7bJ2 -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
