On 09/10/2012 10:32 PM, bastian.rupp...@sewerin.de wrote: > Hello, Prabhakar, hello Tom > >> On Monday 10 September 2012 09:38 PM, Tom Rini wrote: >>> On Sun, Sep 9, 2012 at 11:01 PM, <bastian.rupp...@sewerin.de> wrote: >>>> Hello, >>>> >>>>> Re: [U-Boot] [PATCH v3 5/6] da850/omap-l138: davinci_emac: Suppress >>>>> auto negotiation if needed >>>>> >>>>> On Fri, Sep 7, 2012 at 1:08 AM, Prabhakar Lad >>>>> <prabhakar.cse...@gmail.com> wrote: >>>>>> Hi Bastian, >>>>>> >>>>>> Thanks for the patch. >>>>>> >>>>>> On Thu, Sep 6, 2012 at 11:37 AM, Bastian Ruppert >>>>>> <bastian.rupp...@sewerin.de> wrote: >>>>>>> From this commit id: b78375a806ed04eb22b963255cfdef8df702de47 auto >>>>>>> negotiation is enabled in RMII mode. Some boards based on da850 > need >>>>>>> to suppress this procedure. >>>>>>> >>>>>>> CC: Rajashekhara, Sudhakar <sudhakar....@ti.com> >>>>>>> CC: Lad, Prabhakar <prabhakar....@ti.com> >>>>>>> CC: Hadli, Manjunath <manjunath.ha...@ti.com> >>>>>>> CC: sba...@denx.de >>>>>>> Acked-by: Stefano Babic <sba...@denx.de> >>>>>>> CC: Tom Rini <tr...@ti.com> >>>>>>> Signed-off-by: Bastian Ruppert <bastian.rupp...@sewerin.de> >>>>>>> --- >>>>>>> drivers/net/davinci_emac.c | 3 ++- >>>>>>> 1 files changed, 2 insertions(+), 1 deletions(-) >>>>>>> >>>>>>> diff --git a/drivers/net/davinci_emac.c > b/drivers/net/davinci_emac.c >>>>>>> index b2516d1..fe988d7 100644 >>>>>>> --- a/drivers/net/davinci_emac.c >>>>>>> +++ b/drivers/net/davinci_emac.c >>>>>>> @@ -897,7 +897,8 @@ int davinci_emac_initialize(void) >>>>>>> } >>>>>>> >>>>>>> #if defined(CONFIG_DRIVER_TI_EMAC_USE_RMII) && \ >>>>>>> - defined(CONFIG_MACH_DAVINCI_DA850_EVM) >>>>>>> + defined(CONFIG_MACH_DAVINCI_DA850_EVM) && \ >>>>>>> + !defined(CONFIG_DRIVER_TI_EMAC_RMII_NONEG) >>>>>> instead of CONFIG_DRIVER_TI_EMAC_RMII_NONEG why not have >>>>>> CONFIG_DRIVER_TI_EMAC_RMII_AUTO_NEGOTIATE ? >>>>> >>>>> Good idea, opt-in is better than opt-out, please make it so. >>>>> >>>> >>>> i can see what you mean! But in this case i would like to answer back. >>>> Normally, one almost certainly use the auto negotiation. On the ea20 >>>> board there is a seldom case where auto negotiation is > counterproductive. >>>> In my opinion the feature "disable it" is opt-in. >>>> So i would like to leave it as it is. >>> >>> I will defer to Prabhakar for a final answer on this. >>> >> Ok. 'NONEG' doesn't sound good can you make it NO_NEGOTIATE ? >> > > Ok, i will use CONFIG_DRIVER_TI_EMAC_RMII_NO_NEGOTIATE. It is not too long, > isn´t it? > > Tom, would you like to receive a complete v4 patch series for this? > Or should i post version 4 for the affected patches only?
Whichever is easier for you to post, thanks. -- Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
