Hi Prafulla, On 08/14/2012 03:15 PM, Prafulla Wadaskar wrote: > > >> -----Original Message----- >> From: Valentin Longchamp [mailto:valentin.longch...@keymile.com] >> Sent: 14 August 2012 15:02 >> To: Prafulla Wadaskar >> Cc: u-boot@lists.denx.de; Holger Brunck >> Subject: Re: [PATCH] kw_spi: fix clock prescaler computation >> >> Hi Prafulla, >> >> I haven't received feedback about this patch from you. Can I please >> kindly >> remind you about it since I am about to send patches that deal with >> SPI clk setting. > > Dear Valentin > My bad :-( I am really sorry about this. > I missed this patch. > Please find my comments in lined. > >> >> Thank you. >> >> On 06/29/2012 02:17 PM, Valentin Longchamp wrote: >>> The computation was not correct with low clock values: setting a >> 1MHz >>> clock would result in an overlap that would then configure a 25Mhz >>> clock. >>> >>> This patch implements a correct computation method according to the >>> kirkwood functionnal spec. table 629 (Serial Memory Interface >>> Configuration Register). > > I think this is table 600 (ref: MV-S104860-00 Rev. E specs available on > extranet) > This is a cosmetic change. > > Otherwise I ack for this patch. > > Please kindly let me know, should I pull this patch or you will resend it > with above change?
Ok, I had taken rev. C of the document as a reference, I will resend the patch with the updated commit message. Valentin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
