Hi Stefan, On 08/09/2012 08:09 AM, Stefan Roese wrote: > On 08/08/2012 04:52 PM, Holger Brunck wrote: >> commit 54652991 >> Work around bug in Numonyx P33/P30 256-Mbit 65nm flash chips >> >> fixes a problem for Numonyx P33/P30 flashes for 256-Mbit, but this leads >> to problems for smaller versions of this chip e.g. the 32Mbit version >> with deviceid 0x16 on mgcoge. So move the code for this work around to >> an own function and check previously manufacturer id and device id to >> not break support for other flashes where this work around is not needed. >> >> Signed-off-by: Holger Brunck <holger.bru...@keymile.com> >> Signed-off-by: Heiko Schocher <h...@denx.de> >> cc: Stefan Roese <s...@denx.de> >> cc: Philippe De Muyter <p...@macqel.be> >> cc: Gerlando Falauto <gerlando.fala...@keymile.com> >> --- >> drivers/mtd/cfi_flash.c | 70 >> +++++++++++++++++++++++++++++++--------------- >> 1 files changed, 47 insertions(+), 23 deletions(-) >> >> diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c >> index 35294bc..690748d 100644 >> --- a/drivers/mtd/cfi_flash.c >> +++ b/drivers/mtd/cfi_flash.c >> @@ -1391,6 +1391,43 @@ int write_buff (flash_info_t * info, uchar * src, >> ulong addr, ulong cnt) >> */ >> #ifdef CONFIG_SYS_FLASH_PROTECTION >> >> +#define INTEL_COMPAT 0x89 >> +#define DEV_ID_NUMONYX_256MBIT 0x8922 > > Adding defines in the middle of the source is frowned upon. > > Why don't you use INTEL_MANUFACT from flash.h instead. And add the > device id in this header as well? I would prefer this. >
agreed, I'll prepare a v2. Thanks. Regards Holger _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
