Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <201207282139.05998.ma...@denx.de> you wrote: > > > > include/common.h | 7 +++++++ > > > > 1 file changed, 7 insertions(+) > > > > > > We have similar things already, and we don't add dead code - you add a > > > macro without users here. > > > > It's used in 2/2 ... what macro do you have in mind ? > > Then add it with the patch that uses it.
I really wanted to keep this one separate, but I'll bend here. But if you mention those xstr()s below, it might be actually better to add __stringify() and then replace all those crazy xstr()s. > As for existing use, see for example [...] > include/configs/ima3-mx53.h:#define xstr(s) str(s) Thanks for pointing this out. > > > If you want to unify the use of such a macro, fine - but then please > > > replace all ocurrences of equivalent definitions all over the code. > > All these above (and any I eventually didn't find) should be replaced, > then. Good. > Best regards, > > Wolfgang Denk Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
