Dear Marek Vasut, In message <201207282139.05998.ma...@denx.de> you wrote: > > > > include/common.h | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > We have similar things already, and we don't add dead code - you add a > > macro without users here. > > It's used in 2/2 ... what macro do you have in mind ?
Then add it with the patch that uses it. As for existing use, see for example arch/powerpc/include/asm/processor.h:#define stringify(s) tostring(s) drivers/mtd/ubi/build.c:#include <linux/stringify.h> include/configs/km/keymile-common.h:#define xstr(s) str(s) include/configs/imx27lite-common.h:#define xstr(s) str(s) include/configs/tx25.h:#define xstr(s) str(s) include/configs/mx35pdk.h:#define xstr(s) str(s) include/configs/cam_enc_4xx.h:#define xstr(s) str(s) include/configs/ea20.h:#define xstr(s) str(s) include/configs/MPC8308RDB.h:#define xstr(s) str(s) include/configs/mpc8308_p1m.h:#define xstr(s) str(s) include/configs/flea3.h:#define xstr(s) str(s) include/configs/enbw_cmc.h:#define xstr(s) str(s) include/configs/at91sam9263ek.h:#define xstr(s) str(s) include/configs/amcc-common.h:#define xstr(s) str(s) include/configs/tam3517-common.h:#define xstr(s) str(s) include/configs/manroland/common.h:#define xstr(s) str(s) include/configs/qong.h:#define xstr(s) str(s) include/configs/ima3-mx53.h:#define xstr(s) str(s) > > If you want to unify the use of such a macro, fine - but then please > > replace all ocurrences of equivalent definitions all over the code. All these above (and any I eventually didn't find) should be replaced, then. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de In the bathtub of history the truth is harder to hold than the soap, and much more difficult to find ... - Terry Pratchett, _Sourcery_ _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
