> -----Original Message----- > From: Albert ARIBAUD [mailto:albert.u.b...@aribaud.net] > Sent: 05 July 2012 16:32 > To: Gerlando Falauto > Cc: u-boot@lists.denx.de; Marek Vasut; Longchamp, Valentin; Brunck, > Holger; Prafulla Wadaskar > Subject: Re: [U-Boot] [PATCH] kirkwood: implement kw_sdram_bs_set() > > Hi Gerlando, > > On Thu, 05 Jul 2012 12:57:44 +0200, Gerlando Falauto > <gerlando.fala...@keymile.com> wrote: > > Hi Albert, > > > > On 07/05/2012 12:39 PM, Albert ARIBAUD wrote: > > > Hi Gerlando, > > > > > > On Fri, 29 Jun 2012 13:37:54 +0200, Gerlando Falauto > > > <gerlando.fala...@keymile.com> wrote: > > >> Some boards might be equipped with different SDRAM > configurations. > > >> When that is the case, CPU CS Window Size Register (CS[0]n Size) > > >> should be set to the biggest value through board.cfg file; then > its > > >> value can be fixed at runtime according to the detected SDRAM > size. > > >> > > >> Therefore, implement kw_sdram_bs_set(), to be called for instance > > >> within board_early_init_f(). > > >> > > [...] > > > > > > I don't like isolated patches that seem to create dead code. I > know > > > here it is not the goal, of course; so why not submit a two-patch > > > series, providing both the new code *and* a use for it? > > > > You're absolutely right. > > But mine was more of an interruption/suggestion throughout the > > discussion between Marek and Prafulla... I just didn't want to take > > credit for someone else's code, or create any conflicts with it. > > Understood. Next time, please just add [RFC] in the subject, so that > the patch is not considered for inclusion. > > > I figured it might be quicker (and more fair) that way, perhaps with > > Marek resubmitting it within his own series, or SoB-ing it, because > > in fact mine is just a refactoring of his idea... > > I can of course submit the two-patch series for our boards, if > that's > > OK with Marek. > > That's to be sorted between Marek and you. :)
Hi Gerlando Marek's board support for TK71 is pulled in, may be this patch will be useful for his next board support (if any). BTW: you can always submit it as a part of patch series for your boards. Regards... Prafulla . . . _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
