> -----Original Message----- > From: Valentin Longchamp [mailto:[email protected]] > Sent: 21 June 2012 18:40 > To: Prafulla Wadaskar > Cc: [email protected]; [email protected]; u- > [email protected] > Subject: Re: [U-Boot] [PATCH 12/20] arm/km: add support for external > switchconfiguration > > Hi Prafulla, > > On 06/12/2012 06:39 AM, Prafulla Wadaskar wrote: > > > > > >> -----Original Message----- > >> From: [email protected] [mailto:u-boot- > >> [email protected]] On Behalf Of Valentin Longchamp > >> Sent: 07 June 2012 15:37 > >> To: [email protected] > >> Cc: Valentin Longchamp; [email protected]; u- > >> [email protected] > >> Subject: [U-Boot] [PATCH 12/20] arm/km: add support for external > >> switch configuration > >> > >> This can be used if we do not want to use an EEPROM for the > >> configuration. > >> > >> Signed-off-by: Valentin Longchamp <[email protected]> > >> --- > >> board/keymile/common/common.h | 7 -- > >> board/keymile/km_arm/managed_switch.c | 169 > >> +++++++++++++++++++++++++++++++-- > >> board/keymile/km_arm/managed_switch.h | 99 +++++++++++++++++++ > > > > What is managed switch? Which chip it supports? Why it is sitting > here and not in generic folder? > > > > In this case, the switch is a Marvell 88E52xxx (don't remember the > exact model) > that is connected to the GE port of the Kirkwood and that gets > configured by the > Kirkwood through a MDIO link, using indirect addressing. > > We do not have the pretention to write a generic driver for such > switches/addressing, but we need this functionnality on some boards, > that's why > we have kept it in our own folder and not in a generic driver folder. > > I will add the above precisions to the commit message for an optional > v3 of the > "updates for the Keymile Marvell boards" series so that this is more > clear.
Dear Valentin We must keep develop it as generic driver. Regards... Prafulla . . . _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
