On 06/13/2012 10:19 AM, Simon Glass wrote:
> This provides an option for the LCD to flush the dcache after each update
> (puts, scroll or clear).

> diff --git a/common/cmd_echo.c b/common/cmd_echo.c

> +     /* Use puts() so that the LCD sees it as a new line */
>       if (putnl)
> -             putc('\n');
> +             puts("\n");

That seems fragile - what if someone comes along and uses putc() in some
other code without having a clue that this requirement exists? What
stops putc() from detecting \n just like puts()?
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to