Hi Allen, On Fri, Jun 8, 2012 at 2:16 PM, Allen Martin <amar...@nvidia.com> wrote:
> Add target for tegra20 u-boot image. This is a concatenation of tegra > spl and normal u-boot binaries. > > Signed-off-by: Allen Martin <amar...@nvidia.com> > --- > .gitignore | 1 + > Makefile | 11 +++++++++++ > board/nvidia/seaboard/config.mk | 1 + > 3 files changed, 13 insertions(+) > create mode 100644 board/nvidia/seaboard/config.mk > > diff --git a/.gitignore b/.gitignore > index 0f32fd8..b9192bf 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -39,6 +39,7 @@ > /u-boot.ais > /u-boot.dtb > /u-boot.sb > +/u-boot.t2 > What does t2 mean? If it is a binary file of some sort perhaps u-boot-t2.bin would be better? > > # > # Generated files > diff --git a/Makefile b/Makefile > index b2275ed..6f4abc6 100644 > --- a/Makefile > +++ b/Makefile > @@ -456,6 +456,16 @@ $(obj)u-boot.sb: $(obj)u-boot.bin > $(obj)spl/u-boot-spl.bin > elftosb -zdf imx28 -c $(TOPDIR)/board/$(BOARDDIR)/u-boot.bd\ > -o $(obj)u-boot.sb > > +ifeq ($(CONFIG_OF_SEPARATE),y) > +T2_UBOOT=$(obj)u-boot-dtb.bin > +else > +T2_UBOOT=$(obj)u-boot.bin > +endif > What is this logic for? The dtb file is separate but that doesn't necessarily mean that it must be immediately after the U-Boot image. We provide other options for packaging it, like getenv(). Maybe if you want to create this composite binary you should change its name (u-boot-dtb-t2.bin or u-boot-t2.bin) to indicate what it contains? > +$(obj)u-boot.t2: $(obj)spl/u-boot-spl.bin $(T2_UBOOT) > + $(OBJCOPY) ${OBJCFLAGS} --pad-to=$(PAD_TO) -O binary > $(obj)spl/u-boot-spl $(obj)spl/u-boot-spl-pad.bin > + cat $(obj)spl/u-boot-spl-pad.bin $(T2_UBOOT) > > $(obj)u-boot.t2 > + rm $(obj)spl/u-boot-spl-pad.bin > + > I echo Stephen's comments. But also SPL is supposed to load U-Boot, so shouldn't this t2 binary do that? > ifeq ($(CONFIG_SANDBOX),y) > GEN_UBOOT = \ > cd $(LNDIR) && $(CC) $(SYMS) -T $(obj)u-boot.lds \ > @@ -775,6 +785,7 @@ clobber: tidy > @rm -f $(obj)u-boot.ais > @rm -f $(obj)u-boot.dtb > @rm -f $(obj)u-boot.sb > + @rm -f $(obj)u-boot.t2 > @rm -f $(obj)tools/inca-swap-bytes > @rm -f $(obj)arch/powerpc/cpu/mpc824x/bedbug_603e.c > @rm -f $(obj)arch/powerpc/cpu/mpc83xx/ddr-gen?.c > diff --git a/board/nvidia/seaboard/config.mk b/board/nvidia/seaboard/ > config.mk > new file mode 100644 > index 0000000..71c9f28 > --- /dev/null > +++ b/board/nvidia/seaboard/config.mk > @@ -0,0 +1 @@ > +PAD_TO=0x00208000 > -- > 1.7.9.5 > > Regards, Simon
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot