Hi Stephen, On Mon, May 21, 2012 at 7:49 PM, Stephen Warren <swar...@wwwdotorg.org>wrote:
> On 05/21/2012 06:47 PM, Simon Glass wrote: > > Hi Stephen, > > > > On Mon, May 14, 2012 at 4:13 PM, Stephen Warren <swar...@wwwdotorg.org > > <mailto:swar...@wwwdotorg.org>> wrote: > > > > From: Stephen Warren <swar...@nvidia.com <mailto:swar...@nvidia.com > >> > > > > (In at least some configurations) Whistler uses UART1 on pingroups > > UAA, UAB. > > > diff --git a/arch/arm/cpu/armv7/tegra2/board.c > > > +static int uart_configs[] = { > > +#ifdef CONFIG_TEGRA2_UARTA_UAA_UAB > > + FUNCMUX_UART1_UAA_UAB, > > +#else > > + FUNCMUX_UART1_IRRX_IRTX, > > +#endif > > > > > > We really shouldn't be using configs to deal with this. It should be a > > run-time check. > > > > I recall you saying that we could use the ODM bits for this? > > The ODM bits can indicate which UART is to be used to the debug serial > port, but not the pinmux options. We have no alternative but to make > this a compile-time constant. > To solve this properly we will need a run-time way of selecting the pinmux for UARTs I suppose. We haven't cracked that problem yet. Let's clean this up later. > > > > > + FUNCMUX_UART2_IRDA, > > + -1, > > + FUNCMUX_UART4_GMC, > > + -1, > > +}; > > Regards, Simon
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
