Am Donnerstag 24 Mai 2012, 10:26:44 schrieb Prafulla Wadaskar:
> > +
> > +void kirkwood_mpp_save(void)
>
> This should be
> void kirkwood_mpp_save(unsigned int *mpp_ctrl, int len)
>
> > +{
> > + int i;
> > +
> > + for (i = 0; i < MPP_NR_REGS; i++)
> > + mpp_regs[i] = readl(MPP_CTRL(i));
> > +}
> > +
> > +void kirkwood_mpp_restore(void)
>
> Same here
> void kirkwood_mpp_restore(unsigned int *mpp_ctrl, int len)
or even better kirkwood_mpp_restore(const unsigned int *mpp_ctrl, int len)
btw. sometimes "unsigned int" is used and sometimes "u32", could we agree on
one? Eg. kirkwood_mpp_conf() is declared with unsigned int but defined with
u32.
--
Michael
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
