Hi Joe,
On Wed, Mar 28, 2012 at 12:42 PM, Joe Hershberger <joe.hershber...@ni.com>wrote:
> Signed-off-by: Joe Hershberger <joe.hershber...@ni.com>
> Cc: Joe Hershberger <joe.hershber...@gmail.com>
> Cc: Simon Glass <s...@chromium.org>
> Cc: Mike Frysinger <vap...@gentoo.org>
>
Acked-by: Simon Glass <s...@chromium.org>
A general comment - it would be good to have a short commit message on all
patches.
Regards,
Simon
> ---
> Changes for v2:
> - Split from "Improve variable names and code readability"
> - Fixed comment indention
>
> include/net.h | 2 +-
> net/net.c | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/net.h b/include/net.h
> index 64ecb38..3314b4e 100644
> --- a/include/net.h
> +++ b/include/net.h
> @@ -178,7 +178,7 @@ struct E802_hdr {
> ushort et_prot; /* 802 protocol */
> };
>
> -/* 802 ethernet header size */
> +/* 802 + SNAP + ethernet header size */
> #define E802_HDR_SIZE (sizeof(struct E802_hdr))
>
> /*
> diff --git a/net/net.c b/net/net.c
> index 19d0de6..cac540a 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -901,7 +901,8 @@ NetReceive(uchar *inpkt, int len)
> if (x < 1514) {
> struct E802_hdr *et802 = (struct E802_hdr *)et;
> /*
> - * Got a 802 packet. Check the other protocol field.
> + * Got a 802.2 packet. Check the other protocol
> field.
> + * XXX VLAN over 802.2+SNAP not implemented!
> */
> x = ntohs(et802->et_prot);
>
> --
> 1.6.0.2
>
>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
