Hi Stephen,
On Fri, Apr 13, 2012 at 2:05 PM, Stephen Warren <swar...@wwwdotorg.org> wrote:
> On 04/13/2012 12:29 PM, Simon Glass wrote:
>> Add a NAND controller along with a bindings file for review.
>>
>> Signed-off-by: Simon Glass <s...@chromium.org>
>
>> +++ b/doc/device-tree-bindings/nand/nvidia-nand.txt
>
> I'd prefer this be called nvidia,tegra20-nand.txt so filenames are named
> according to compatible value. This makes it easier to look things up.
OK, changed
>
>> +The device node for a NAND flash device is as described in the document
>> +"Open Firmware Recommended Practice : Universal Serial Bus" with the
>
> This is really based on USB?
Well just in that it follows the conventions. I will remove this since
I'm not sure we use anything that isn't in the ePAPR.
>
>> +Required properties :
>> + - compatible : Should be "manufacture,device", "nand-flash"
>> + - nvidia,page-data-bytes : Number of bytes in the data area
>> + - nvidia,page-spare-bytes : * Number of bytes in spare area
>
> Not sure what that "*" is?
Removed
>
>> +Nvidia NAND Controller
>> +----------------------
>> +
>> +The device node for a NAND flash controller is as described in the document
>> +"Open Firmware Recommended Practice : Universal Serial Bus" with the
>
> USB again?
Removed
>
>> +nand-controller@0x70008000 {
>> + compatible = "nvidia,tegra20-nand";
>> + wp-gpios = <&gpio 59 0>; /* PH3 */
>> + nvidia,width = <8>;
>> + nvidia,timing = <26 100 20 80 20 10 12 10 70>;
>> + nand@0 {
>> + compatible = "hynix,hy27uf4g2b", "nand-flash";
>
> The TRM says there can be up to 8 chip selects. Don't the NAND device
> sub-nodes need a reg property to indicate which chip-select they're on?
We don't have driver support for this at present.
>
> Also, the TRM mentions async vs. ONFI devices. Don't we need properties
> somewhere to configure that kind of thing?
We don't have driver support for this at present, either :-(
>
>> + nvidia,page-data-bytes = <2048>;
>> + nvidia,tag-ecc-bytes = <4>;
>> + nvidia,tag-bytes = <20>;
>> + nvidia,data-ecc-bytes = <36>;
>> + nvidia,skipped-spare-bytes = <4>;
>> + nvidia,page-spare-bytes = <64>;
>> + };
>> +};
Regards,
Simon
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
