Dear Minkyu,
On 15 March 2012 06:53, Minkyu Kang <proms...@gmail.com> wrote:
> Dear Chander Kashyap,
>
> On 14 March 2012 22:38, Chander Kashyap <chander.kash...@linaro.org> wrote:
>> Hi Kyungmin Park,
>>
>> On 14 March 2012 19:02, Kyungmin Park <kmp...@infradead.org> wrote:
>>> Hi Chander,
>>>
>>> On Wed, Mar 14, 2012 at 10:14 PM, Chander Kashyap
>>> <chander.kash...@linaro.org> wrote:
>>>> TZPC IP is common across S5P and Exynos based SoC'c. Renaming exynos5_tzpc
>>>> in arch/arm/include/asm/arch-exynos/tzpc.h to s5p_tzpc will allow generic
>>>> usase of tzpc.
>>>>
>>>> Also modify board/samsung/smdk5250/tzpc_init.c to use s5p_tzpc.
>>>>
>>>> Signed-off-by: Chander Kashyap <chander.kash...@linaro.org>
>>>> ---
>>>> arch/arm/include/asm/arch-exynos/tzpc.h | 2 +-
>>>> board/samsung/smdk5250/tzpc_init.c | 2 +-
>>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/arch/arm/include/asm/arch-exynos/tzpc.h
>>>> b/arch/arm/include/asm/arch-exynos/tzpc.h
>>>> index 2c9a07b..63736ae 100644
>>>> --- a/arch/arm/include/asm/arch-exynos/tzpc.h
>>>> +++ b/arch/arm/include/asm/arch-exynos/tzpc.h
>>>> @@ -22,7 +22,7 @@
>>>> #define __TZPC_H_
>>>>
>>>> #ifndef __ASSEMBLY__
>>>> -struct exynos5_tzpc {
>>>> +struct s5p_tzpc {
>>> I think 'exynos' is preferable. Even though each SOC has different
>> I tried to carry forward old conventions as in case of watchdog. I
>> will change it to exynos.
>
> I agreed with Kyungmin.
> From now, let's called "exynos" for common name including s5pc1xx and
> s5pc2xx and exynos4 and exynos5.. etc.
Thanks for the inputs. Let us follow the convention. I will resubmit the patch.
>
>>
>>> number of tzpc. It can be covered one exynos_tzpc. or we can define
>>> it for each SoC.
>> One structure is enough as fields are same.
>>
>
> Thanks
> Minkyu Kang.
> --
> from. prom.
> www.promsoft.net
--
with warm regards,
Chander Kashyap
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
