Hi Wolfgang,

On Wednesday 07 March 2012 05:35 PM, Wolfgang Denk wrote:
Dear Prabhakar Kushwaha,

In message<4f56deb0.6060...@freescale.com>  you wrote:
+       _mas0 = MAS0_TLBSEL(1) |
+                       MAS0_ESEL(CONFIG_DEBUGGER_TEMP_TLB);
You are using an undocumented CONFIG_ option here.
This CONFIG_ is defined as part of documentation patch sent in this series
CONFIG_ options must be documented in the README.

Sure

+#if defined(CONFIG_E500_V1_V2)&&   !defined(CONFIG_SYS_RAMBOOT)
What if no such debug support is needed, and code size hurts?
sure it will. I agree with you.
But this piece of code overcome debug restriction of e500 and e500v2
cores and  I think fixing restriction is a good way to go.
What do we do to disable this code if no debug support is needed, and
the code size is considered critical?

i will put this piece of code under #if defined (CONFIG_DEBUGGER_TEMP_TLB). This piece of code will only be enabled when someone wants debugging here. And the requirement is temporary TLB.

+#define CONFIG_DEBUGGER_TEMP_TLB       3
Undocumented!

This CONFIG_ is defined as part of documentation patch sent in this series
This is not sufficient, see above.

i will add the description.

Regards,
Prabhakar




_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to