On 01/09/2012 11:28 AM, Sughosh Ganu wrote: > This patch moves hawkboard to the new spl infrastructure from the > older nand_spl one. Making this change required some code refactoring > with a couple of davinci based platforms which use spl. > > Removed the hawkboard_nand_config build option -- The spl code now > gets compiled with hawkboard_config, after building the main u-boot > image, using the CONFIG_SPL_TEXT_BASE. Modified the README.hawkboard > to reflect the same. [snip]
On the whole, I'm happy, but: [snip] > --- a/arch/arm/cpu/arm926ejs/davinci/Makefile > +++ b/arch/arm/cpu/arm926ejs/davinci/Makefile > @@ -38,8 +38,11 @@ COBJS-$(CONFIG_DRIVER_TI_EMAC) += lxt972.o dp83848.o > et1011c.o ksz8873.o > > ifdef CONFIG_SPL_BUILD > COBJS-y += spl.o > -COBJS-$(CONFIG_SOC_DM365) += dm365_lowlevel.o > -COBJS-$(CONFIG_SOC_DA8XX) += da850_lowlevel.o > +COBJS-$(CONFIG_DM365_SPL) += dm365_lowlevel.o > +COBJS-$(CONFIG_DM365_SPL) += dm365_spl.o > +COBJS-$(CONFIG_DA850EVM_SPL) += da850_lowlevel.o > +COBJS-$(CONFIG_DA850EVM_SPL) += da850_spl.o > +COBJS-$(CONFIG_HAWKBOARD_SPL) += hawkboard_nand_spl.o > endif CONFIG_SPL_BUILD means we'll only do this on the SPL build, not the normal build, and we already have symbols for the board and the SoC so we shouldn't need any new CONFIG symbols here, I'm pretty sure. -- Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
