Dear "HeungJun, Kim",
In message <01b801ccce94$b2599a00$170cce00$%k...@samsung.com> you wrote:
>
...
> > > + writel(0, base + POWER_TV_CONFIGURATION_OFFSET);
> > > + writel(0, base + POWER_MFC_CONFIGURATION_OFFSET);
> > > + writel(0, base + POWER_G3D_CONFIGURATION_OFFSET);
> > > + writel(0, base + POWER_LCD_CONFIGURATION_OFFSET);
> > > + writel(0, base + POWER_GPS_CONFIGURATION_OFFSET);
> > >
> > Please use structures instead of defines.
> I found there is only the definition EXYNOS4_POWER_BASE, not a structure
> about the power in the arch/arm/include/asm/arch-exynos/*.
>
> So, I think it's good to put pmu_init() as this for now, and
> to change after including the definitions and structures about the power.
No, this is not acceptable. It's the other way round: first add the
needed data structures, then add the code that uses these.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
How many seconds are there in a year? If I tell you there are 3.155 x
10^7, you won't even try to remember it. On the other hand, who could
forget that, to within half a percent, pi seconds is a nanocentury.
-- Tom Duff, Bell Labs
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
