On 12/15/2011 04:53 AM, Liu Shengzhou-B36685 wrote:
>>>> -----Original Message-----
>>>> From: Wood Scott-B07421
>>>> Sent: Tuesday, December 13, 2011 4:14 AM
>>>> To: Liu Shengzhou-B36685
>>>> Cc: u-boot@lists.denx.de; Gala Kumar-B11780; Liu Shuo-B35362
>>>> Subject: Re: [PATCH 5/5 v2] mtd/nand: workaround for Freescale FCM to
>>>> support 4k pagesize Nand chip
>>
>>>>> + nand->ecc.layout = (priv->fmr & FMR_ECCM) ?
>>>>> + &fsl_elbc_oob_lp_eccm1 : &fsl_elbc_oob_lp_eccm0;
>>>>> + nand->badblock_pattern = &largepage_memorybased;
>>>>
>>>> Those oob layouts won't be quite right for larger page sizes.
>>>>
>>>> -Scott
>>> [Shengzhou] It's the same with what Linux does. What's the right?
>>
>> I think we need to explicitly define 4096 and 8192 variants, with the
>> extra eccpos/oobfree. Or generate them programatically.
>>
>> -Scott
>
> [Shengzhou]
> You mean we should define something like below?
> static struct nand_ecclayout fsl_elbc_oob_lp_4k_eccm0 = {
> .eccbytes = 24,
> .eccpos = {6, 7, 8, 22, 23, 24, 38, 39, 40, 54, 55, 56,
> 70, 71, 72, 86, 87, 88, 102, 103, 104, 118, 119, 120},
> .oobfree = { {1, 5}, {9, 13}, {25, 13}, {41, 13}, {57, 7},...... },
> };
> static struct nand_ecclayout fsl_elbc_oob_lp_8k_eccm0 = {........};
Yes.
> eLBC RM says:
> ECC is checked/calculated over 512-Byte blocks. A 24-bit ECC is assigned to
> spare region bytes at offsets
> (N × 16) + 6 through (N × 16) + 8 for spare region N, N = 0–3. (for ECCM=0
> case)
>
> Here RM just says N is 0–3, but it should be 0-7 for 4096 case,
Well, yes, this is a hack to do things that the hardware doesn't
officially support.
> hardware ECC doesn't generate ECC in position of N=4,5,6,7.
It will. It just thinks that N=0,1,2,3.
> fsl_elbc_oob_lp_eccm0 and fsl_elbc_oob_lp_eccm1 are controller-associated,
> not device-associated,
Then why do we have separate small and large page versions?
> I think we don't need define 4096 and 8192 variants, it's emulating 4096/8192
> case by
> the existing 2K layout of fsl_elbc_oob_lp_eccm0 and fsl_elbc_oob_lp_eccm1.
> Please correct me if any wrong understanding.
It's supporting 4096/8192 by repeating the 2048 layout multiple times.
This repetition is not captured by the existing nand_ecclayout.
-Scott
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
