On 09/12/2011 12:29, Wolfgang Denk wrote: > Dear Stefano Babic, > > In message <1323426220-30366-1-git-send-email-sba...@denx.de> you wrote: >> commit 0910d0bcb85acdf09b9dfd8ded452367b540a4ad >> Mike Partington <mpart...@lexmark.com> >> Date: Wed Oct 27 10:31:09 2010 +0000 >> >> Standalone Apps: Standalone apps should need only exports.h. >> >> Modify exports.h to remove its dependencies on other files, thus >> enabling standalone apps to require only exports.h from the U-Boot >> source tree. This appears to be the intent based on the following >> note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html >> >> breaks all boards - the fact is that common.h is not included anymore >> by exports.h, and this breaks the build of several file. > > Do we accept such a patch?
Yes - it is already in mainline > > >> --- a/include/common.h >> +++ b/include/common.h >> @@ -35,6 +35,7 @@ typedef volatile unsigned short vu_short; >> typedef volatile unsigned char vu_char; >> >> #include <config.h> >> +#include <assert.h> >> #include <asm-offsets.h> >> #include <linux/bitops.h> >> #include <linux/types.h> > > This appears to be an unrelated change, that should be submitted > separately. This seems to be, it is not - or not strictly. The problem rises with lib/qsort.c, that could be used (am I right ?) by standalone program and can import only export.h > Also, we should then remove the "#include <assert.h>" > from files that have this and also include common.h (that would be at > least common/hwconfig.c). There is not yet an assert.h, I have introduced with this patch. This avoid to include common.h in qsort.c, if qsort can be used in standalone programs and importing common.h is not allowed. Of course, if I am wrong, qsort can include directly common.h. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
