Dear Stefano Babic, In message <[email protected]> you wrote: > commit 0910d0bcb85acdf09b9dfd8ded452367b540a4ad > Mike Partington <[email protected]> > Date: Wed Oct 27 10:31:09 2010 +0000 > > Standalone Apps: Standalone apps should need only exports.h. > > Modify exports.h to remove its dependencies on other files, thus > enabling standalone apps to require only exports.h from the U-Boot > source tree. This appears to be the intent based on the following > note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html > > breaks all boards - the fact is that common.h is not included anymore > by exports.h, and this breaks the build of several file.
Do we accept such a patch? > --- a/include/common.h > +++ b/include/common.h > @@ -35,6 +35,7 @@ typedef volatile unsigned short vu_short; > typedef volatile unsigned char vu_char; > > #include <config.h> > +#include <assert.h> > #include <asm-offsets.h> > #include <linux/bitops.h> > #include <linux/types.h> This appears to be an unrelated change, that should be submitted separately. Also, we should then remove the "#include <assert.h>" from files that have this and also include common.h (that would be at least common/hwconfig.c). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] Don't have a battle of wits with an unarmed opponent. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
