Hi Stefano, On 07.12.2011 13:06, Stefano Babic wrote: >> +#ifndef CONFIG_SPL_NAND_WORKSPACE >> +#define CONFIG_SPL_NAND_WORKSPACE (CONFIG_SYS_SDRAM_BASE + 0x10000) >> +#endif > > Maybe it is better to not have a default value somewhere in the SDRAM > and to get a compile error. If we do not want to fix also the related
My intention was not to break something as I can't fix every board using this driver. That's why I preserved the existing address for the case where CONFIG_SPL_NAND_WORKSPACE is not defined. > boards, we could at least use a #warn message to advise at compile time > that a default value is taken (and at the end, to force the board > maintainers to fix it...). Probably. Wolfgang, Scott, do you think we should add a warning here? Regards, Ilya. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
