On 11/28/11 17:28, Wolfgang Denk wrote:
> Dear Igor Grinberg,
>
> it is really not necessary to quote 1300+ lines of unrelated code.
> Just provide sufficient context for your remarks.
>
> In message <4ed373c6.5020...@compulab.co.il> you wrote:
>>
>>> + ret = gpio_request(gpio, enbw_gpio_config[i].name);
>>> + if (ret)
>>> + printf("%s: Could not get %s gpio\n", __func__,
>>> + enbw_gpio_config[i].name);
>>> + else
>>
>> instead of having that else and adding another level of indentation below
>> you can just add continue;
>
> Really? There is no return in this error handling, so why do you
> think we should continue to run this code even after an error?
That's what the original code does, but a bit uglier...
Probably you are right, but I think it should be up to
the board maintainer to decide, because not all GPIOs are related
to each other and failing to request one of them, does not
have to affect the others and in that case, the error message
is printed, which should be enough to understand that there is
a problem.
--
Regards,
Igor.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
