Hello Wolfgang,

Wolfgang Denk schrieb:
> Dear Heiko Schocher,
> 
> In message <4ed3a6a8.5010...@denx.de> you wrote:
>>>> +          ret = gpio_request(gpio, enbw_gpio_config[i].name);
>>>> +          if (ret)
>>>> +                  printf("%s: Could not get %s gpio\n", __func__,
>>>> +                          enbw_gpio_config[i].name);
>>>> +          else
>>> instead of having that else and adding another level of indentation below
>>> you can just add continue;
>> Done.
> 
> Is this really a good idea??

Fixed that. If there is an error, we return instead.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to