On Fri, Nov 25, 2011 at 9:39 AM, Marek Vasut <marek.va...@gmail.com> wrote:
>> board.c: In function 'board_init_r':
>> board.c:280:8: warning: unused variable 's'
>>
>> Signed-off-by: Daniel Schwierzeck <daniel.schwierz...@googlemail.com>
>> ---
>> arch/mips/lib/board.c | 3 +--
>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c
>> index 9585db7..aac7690 100644
>> --- a/arch/mips/lib/board.c
>> +++ b/arch/mips/lib/board.c
>> @@ -266,7 +266,6 @@ void board_init_r(gd_t *id, ulong dest_addr)
>> #ifndef CONFIG_ENV_IS_NOWHERE
>> extern char *env_name_spec;
>> #endif
>> - char *s;
>> bd_t *bd;
>>
>> gd = id;
>> @@ -347,7 +346,7 @@ void board_init_r(gd_t *id, ulong dest_addr)
>> /* Initialize from environment */
>> load_addr = getenv_ulong("loadaddr", 16, load_addr);
>> #if defined(CONFIG_CMD_NET)
>> - s = getenv("bootfile");
>> + const char *s = getenv("bootfile");
>> if (s)
>> copy_filename(BootFile, s, sizeof(BootFile));
>> #endif
>
> Are you sure about this "const" thing? Also, try compiling the stuff with
> gcc4.6, it'll reveal more errors.
>
yes, s is only used in the if and as parameter for copy_filename. The
function signature
also have const:
extern void copy_filename (char *dst, const char *src, int size);
And gcc-4.6.2 compiles that part without warnings.
--
Best regards,
Daniel
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
