Hello Prabhakar Lad,
Prabhakar Lad wrote:
> Hi Heiko,
>
> On Wed, Nov 9, 2011 at 11:56 AM, Heiko Schocher <h...@denx.de> wrote:
[...]
>> Signed-off-by: Heiko Schocher <h...@denx.de>
>> Cc: Sandeep Paulraj <s-paul...@ti.com>
>> Cc: Albert ARIBAUD <albert.u.b...@aribaud.net>
>> Cc: Wolfgang Denk <w...@denx.de>
>> Cc: Manjunath Hadli <manjunath.ha...@ti.com>
>> ---
>> drivers/net/davinci_emac.c | 17 +++++++++++------
>> 1 files changed, 11 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
>> index fa31159..a31e9f1 100644
>> --- a/drivers/net/davinci_emac.c
>> +++ b/drivers/net/davinci_emac.c
[...]
>> @@ -175,7 +174,13 @@ static int davinci_eth_phy_detect(void)
>> for (i = 0, j = 0; i < 32; i++)
>> if (phy_act_state & (1 << i)) {
>> count++;
>> - active_phy_addr[j++] = i;
>> + if (count < MAX_PHY)
>> + active_phy_addr[j++] = i;
>> + else {
>> + printf("%s: to much PHYs detected.\n",
>> + __func__);
>>
> why not make here count = 0 and then break, so that later
> in davinci_emac_initialize() it wont initializes the phy's
I prefer here the error printf, because you see immediately what
is wrong...
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
