> On Tuesday 25 October 2011 05:39:58 Marek Vasut wrote: > > --- a/drivers/usb/eth/smsc95xx.c > > +++ b/drivers/usb/eth/smsc95xx.c > > > > - addr_lo = cpu_to_le32(*((u32 *)eth->enetaddr)); > > + addr_lo = cpu_to_le32(*eth->enetaddr); > > pretty sure this is wrong. enetaddr is a uchar[], so your code now reads > only 1 byte instead of 4. > > that said, this code also seems to not be endian safe ... > -mike
It's good anyone actually cares to properly review. Anyway, why does noone actually care to fix all the damn warnings in their drivers before submitting them in the first place ?! _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
