Hi Tom, On Wed, Oct 26, 2011 at 1:38 PM, Tom Rini <tom.r...@gmail.com> wrote: > On Wed, Oct 26, 2011 at 1:34 PM, Wolfgang Denk <w...@denx.de> wrote: >> Dear Simon Glass, >> >> In message <1319515208-7810-7-git-send-email-...@chromium.org> you wrote: >>> We want to show block markers on completion of get and put, so >>> move this common code into separate functions. >>> >>> Signed-off-by: Simon Glass <s...@chromium.org> >>> --- >>> net/tftp.c | 68 >>> +++++++++++++++++++++++++++++++++-------------------------- >>> 1 files changed, 38 insertions(+), 30 deletions(-) >> >> ARRRRRRGHHH!!!! >> >> Your commits are not bisectable. >> >> When applying your commits up to and including this one, all boards >> with ethernet support will break with errors like this: >> >> >> net.c: In function 'NetLoop': >> net.c:412: error: too many arguments to function 'TftpStart' >> make[1]: *** [/work/wd/tmp-ppc/net/net.o] Error 1 >> >> >> Please always make sure that patches are really orthogonal so we can >> use git bisect! > > https://github.com/dustin/bindir/blob/master/git-test-sequence is very > helpful in > the "make sure my whole pull request is bisectable" area.
Yes that is useful - thanks very much. Even more useful if my build procedure is actually building the code in the commits :-) Regards, Simon > > -- > Tom > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
