Hi Wolfgang, On Wed, Oct 26, 2011 at 1:34 PM, Wolfgang Denk <w...@denx.de> wrote: > Dear Simon Glass, > > In message <1319515208-7810-7-git-send-email-...@chromium.org> you wrote: >> We want to show block markers on completion of get and put, so >> move this common code into separate functions. >> >> Signed-off-by: Simon Glass <s...@chromium.org> >> --- >> net/tftp.c | 68 >> +++++++++++++++++++++++++++++++++-------------------------- >> 1 files changed, 38 insertions(+), 30 deletions(-) > > ARRRRRRGHHH!!!! > > Your commits are not bisectable. > > When applying your commits up to and including this one, all boards > with ethernet support will break with errors like this: > > > net.c: In function 'NetLoop': > net.c:412: error: too many arguments to function 'TftpStart' > make[1]: *** [/work/wd/tmp-ppc/net/net.o] Error 1 > > > Please always make sure that patches are really orthogonal so we can > use git bisect!
OK, will do. It was my intention but I just realised that my per-commit testing was done without CMD_NET enabled. Duh! For the record the problem above (plus another one) affect all of these commits: 8fd7848 net: tftpput: implement tftp logicaca9411 net: tftpput: add saveaddr and savesize env variablesc345a74 net: tftpput: Support selecting get/put for tftp7d89bd6 net: tftpput: Factor out start, restart and next block functions9405b23 net: tftpput: move common code into separate functions188f301 net: tftpput: Rename TFTP to TFTPGET Regards, Simon > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > War is never imperative. > -- McCoy, "Balance of Terror", stardate 1709.2 > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
