On 10/26/2011 01:16 AM, Heiko Schocher wrote:
> Hello Scott,
>
> Scott Wood wrote:
>> It's not new, but it is misnamed (there's nothing 4-bit specific in the
>> #ifdeffed code), and we now have someone that wants this for 8-bit ECC.
>
> look at my v4 series of this patchset:
>
> http://patchwork.ozlabs.org/patch/121295/
>
> I renamed it to: CONFIG_SYS_NAND_HW_ECC_OOBFIRST
OK. I just got back from vacation, so I'm still going through an e-mail
backlog.
> In drivers/mtd/nand/davinci_nand.c CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST
> is used, and there are 4bit specific functions, so this define is
> also valid, just we need in drivers/mtd/nand/nand_spl_simple.c a more
> common name, right?
Right. Ideally, though, that would either be CONFIG_SYS_DAVINCI_... or
#if defined(CONFIG_SYS_NAND_HW_ECC_OOBFIRST) && \
defined(CONFIG_SYS_NAND_HW_ECC_4BIT)
-Scott
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
