On Wednesday 19 October 2011 04:37:26 Eibach, Dirk wrote: > > While looking again, I noticed that you are not using the > > "standard" GPIO API borrowed from Linux. Please take a look > > at drivers/gpio/mxc_gpio.c or drivers/gpio/mvgpio.c as an example. > > > > Sorry for not mentioning this earlier. Could you please > > update this patch and your Io64 BSP patch by using this > > "standard" GPIO API? > > I see that the drivers you mentioned are for processor gpio, mine is for > an i2c port expander. > The gpio API "implementation" in these drivers is a mess because it does > not support managing multiple gpio providers. Using this API would make > it impossible to use pca9698 on such platforms. If someone decided to > build a processor gpio driver like this for ppc4xx we would even have a > collision for Io64. > > Until the whole GPIO API idea is more refined I am not too happy > adapting pca9698 implementation. > Do you insist?
the GPIO API is not specific to processors. atm, only SoC's are implementing it. what you're looking for is the gpiolib which Linux supports. we haven't bothered adding that layer yet as no one was adding GPIO expanders. you still have your API logically line up with the common GPIO API so that when said layer lands, it's easy to transition to. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
