Hi Anatolij, On Tue, Oct 18, 2011 at 3:17 PM, Anatolij Gustschin <ag...@denx.de> wrote: > Hi, > > On Tue, 18 Oct 2011 14:12:59 +0800 > Che-liang Chiou <clch...@chromium.org> wrote: > ... >> > Many boards defining CONFIG_LCD also define CONFIG_LCD_LOGO. >> > Enabling CONFIG_API for such board configurations will break >> > compiling, e.g.: >> > >> > $ ./MAKEALL TQM823L_LCD >> > Configuring for TQM823L_LCD - Board: TQM823L, Options: LCD,NEC_NL6448BC20 >> > api_display.c: In function 'display_get_info': >> > api_display.c:40: error: 'BMP_LOGO_HEIGHT' undeclared (first use in this >> > function) >> > api_display.c:40: error: (Each undeclared identifier is reported only once >> > api_display.c:40: error: for each function it appears in.) >> > make[1]: *** [api_display.o] Error 1 >> > make: *** [api/libapi.o] Error 2 >> > >> > Any idea how to fix this issue? >> > >> >> BMP_LOGO_HEIGHT is defined bmp_logo.h, which is automatically >> generated by tools/bmp_logo.c when CONFIG_LCD_LOGO or >> CONFIG_VIDEO_LOGO is set. So I guess this is quite easy to fix. We >> could include bmp_logo.h in api_display.c. > > This won't work I'm afraid. bmp_logo.h is included elsewhere an including > it in libapi will cause multiple definition of `bmp_logo_bitmap' and > `bmp_logo_palette' compile errors. > > Thanks, > Anatolij >
I was planning to add a 'static __attribute__((unused))' to it to avoid this problem. What do you think? Regards, Che-Liang _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
