Hi Wolfgang Denk, I have added following comments to this call in patch V2. + /*+ * This only clears messages on screen, not on serial port. It is+ * equivalent to a no-op if no display is available.+ */Do you think it is sufficient?
Regards, Che-Liang On Fri, Oct 7, 2011 at 5:05 PM, Wolfgang Denk <w...@denx.de> wrote: > Dear Che-liang Chiou, > > In message > <canjuy2kuhg+4kueeupj0pbefkjdhajjnt_8-vulxyuxh9oc...@mail.gmail.com> you > wrote: >> >> >> + ub_display_clear(); >> > >> > What happens here if no display is available? >> >> It is equivalent to a no-op. Or do you think we should print a warning >> message if no display is available? > > Please either add an if() and don;t run the function at all, or add a > comment that explains that this callis harmless if no display is > present. > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > "He was so narrow minded he could see through a keyhole with both > eyes ..." > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
