Dear Jason, In message <20111014131245.gf7...@titan.lakedaemon.net> you wrote: > > 1.) checkpatch.pl complained about volatile in source.c:312. This is > a register we bitbang in a loop and we don't want the compiler > optimizing it out.
This would, in almost all cases, trigger a NAK due to the fact that device register accesses should be done through I/O accesors, and never through volatile pointers. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A quarrel is quickly settled when deserted by one party; there is no battle unless there be two. - Seneca _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
