Hi Mike,
On Thu, Oct 13, 2011 at 4:01 PM, Mike Frysinger <vap...@gentoo.org> wrote:
> On Thursday 13 October 2011 17:28:10 Simon Glass wrote:
>> On Thu, Oct 13, 2011 at 1:33 PM, Mike Frysinger wrote:
>> > On Tuesday 11 October 2011 18:26:11 Simon Glass wrote:
>> >> +int fdtdec_next_alias(const void *blob, const char *name,
>> >> + enum fdt_compat_id id, int *upto)
>> >> +{
>> >> +#define MAX_STR_LEN 20
>> >> + char str[MAX_STR_LEN + 20];
>> >> + int node, err;
>> >> +
>> >> + sprintf(str, "%.*s%d", MAX_STR_LEN, name, *upto);
>> >
>> > where's that "20" coming from ? just arbitrarily defined ? might want
>> > to add an assert(strlen(name) <= MAX_STR_LEN).
>>
>> OK. Of course I would like to use snprintf()...
>
> i think that might be nicer anyways than %.*s
>
> char str[40]; /* an arbitrary len */
> snprintf(str, sizeof(str), "%s%d", name, *upto);
> -mike
>
Yes I agree, but we have the minor issue that snprintf() is not merged yet :-(
Regards,
Simon
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
