On Saturday, October 08, 2011 11:18:28 PM Mike Frysinger wrote: > On Saturday 08 October 2011 15:21:17 Marek Vasut wrote: > > On Saturday, October 08, 2011 09:06:30 PM Mike Frysinger wrote: > > > On Friday 07 October 2011 16:10:11 Marek Vasut wrote: > > > > On Friday, October 07, 2011 07:38:19 PM Mike Frysinger wrote: > > > > > On Friday 07 October 2011 08:30:55 Marek Vasut wrote: > > > > > > Also, fix usb drivers which use extern new. > > > > > > > > > > this summary/changelog is lacking in information as to what you > > > > > actually did and why ... > > > > > > > > Hi Mike, generally shuffling with code, abstracting out some things, > > > > making it checkpatch-comformant. Also, addition of generic key report > > > > code when polling. > > > > > > it's hard to evaluate each piece by itself when it's just one patch > > > smooshing it all together > > > > Well how would you rework crap code piece by piece? > > - fix style > - abstract out stuff
Not like there was so much abstraction it couldn't be squashed into this one. > - add new generic key support True, this could be separated out. Well, Remy ... what do you think? > > i'm not the usb maintainer, so if Remy is fine with the work as he can > follow it, then that's fine. i'm not terribly familiar with internal usb > code, so it's hard to pick out what's going on. > -mike No prob. Thanks for the review. Cheers! _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
