Hello Christian, Christian Riesch wrote: > Hello Heiko, > >>> Which brings me to my next point: AFAIK Texas Instruments's AM18xx >>> SoCs, their OMAP-L138, and their DA850 based devices basically differ >>> only in the DSP/PRU part of the device. If you are (like in u-boot) >>> only interested in the ARM part of chip, they are basically the same >>> device. For some reason the Linux kernel and u-boot support for all >>> these devices is labelled da850... Although I have no hardware to test >>> it, I guess that your DDR memory controller initialization code could >>> be used for the OMAP-L138 and the corresponding Davinci device as >>> well. So since all code in u-boot for the entire device family is >>> labelled da850... I guess your DDR initialization functions should get >>> this prefix as well for consistency. Any comments from the >>> maintainers/TI employees who know these devices better than I do? >> Yes of course, such a rename should be done, if somebody has tested it! > > I just wonder what is worse, having code in there that is labelled > da850 but not tested on all devices of the family, or having it > renamed every time someone finds out that it also runs on other > devices. TI uses a common PLL initialization code in its User Boot > Loader (UBL) for OMAP-L138, DA850, AM180x, so it should be pretty save > to rename it right now.
Feel free to sent a patch ;-) > Did you also read the rest of my last email, the PSC part? Yep, and I sent a response here: http://lists.denx.de/pipermail/u-boot/2011-September/102340.html bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
