On Wed, Sep 14, 2011 at 08:11, Marek Vasut wrote: > On Wednesday, September 14, 2011 09:17:37 AM Stefano Babic wrote: >> On 09/12/2011 06:06 AM, Marek Vasut wrote: >> > --- a/drivers/net/fec_mxc.c >> > +++ b/drivers/net/fec_mxc.c >> > >> > +/* >> > + * The i.MX28 operates with packets in big endian. We need to swap them >> > before + * sending and after receiving. >> > + */ >> > +#ifdef CONFIG_MX28 >> > +#define CONFIG_FEC_MXC_SWAP_PACKET >> > +#endif >> >> Do we really need two defines ? If the MX28 has the oddity to swap >> packets and this must be always done for this SOC, we could protect the >> code only with CONFIG_MX28. I think in the code it is already clear that >> in case of MX28 the packets are swapped. > > Well if any other CPU with this problem pops up on the market, we should be > ready.
makes sense -mike _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
