On Wednesday, September 14, 2011 09:17:37 AM Stefano Babic wrote: > On 09/12/2011 06:06 AM, Marek Vasut wrote: > > Signed-off-by: Marek Vasut <marek.va...@gmail.com> > > Cc: Ben Warren <biggerbadder...@gmail.com> > > Cc: Stefano Babic <sba...@denx.de> > > Cc: Wolfgang Denk <w...@denx.de> > > Cc: Detlev Zundel <d...@denx.de> > > --- > > Hi Marek, > > only a small question: > > drivers/net/fec_mxc.c | 44 > > ++++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 42 > > insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c > > index cfe2176..f50433dd 100644 > > --- a/drivers/net/fec_mxc.c > > +++ b/drivers/net/fec_mxc.c > > @@ -42,6 +42,14 @@ DECLARE_GLOBAL_DATA_PTR; > > > > #define CONFIG_FEC_XCV_TYPE MII100 > > #endif > > > > +/* > > + * The i.MX28 operates with packets in big endian. We need to swap them > > before + * sending and after receiving. > > + */ > > +#ifdef CONFIG_MX28 > > +#define CONFIG_FEC_MXC_SWAP_PACKET > > +#endif > > + > > Do we really need two defines ? If the MX28 has the oddity to swap > packets and this must be always done for this SOC, we could protect the > code only with CONFIG_MX28. I think in the code it is already clear that > in case of MX28 the packets are swapped.
Well if any other CPU with this problem pops up on the market, we should be ready. > > Best regards, > Stefano Babic _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
