> -----Original Message----- > From: Ajay Bhargav [mailto:ajay.bhar...@einfochips.com] > Sent: Tuesday, July 19, 2011 9:41 AM > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik > Subject: Re: [PATCH 3/4] Armada100: Enable 88E3015 PHY support for > GplugD > > > ----- "Prafulla Wadaskar" <prafu...@marvell.com> wrote: > > > > -----Original Message----- > > > From: Ajay Bhargav [mailto:ajay.bhar...@einfochips.com] > > > Sent: Monday, July 18, 2011 3:12 PM > > > To: Prafulla Wadaskar > > > Cc: u-boot@lists.denx.de; Ajay Bhargav > > > Subject: [PATCH 3/4] Armada100: Enable 88E3015 PHY support for > > GplugD > > > > > > This patch adds support for 88E3015 PHY for Marvell GplugD board. > > > > > > Signed-off-by: Ajay Bhargav <ajay.bhar...@einfochips.com> > > > --- > > > board/Marvell/gplugd/gplugd.c | 35 > > > +++++++++++++++++++++++++++++++++++ > > > include/configs/gplugd.h | 14 ++++++++++++++ > > > 2 files changed, 49 insertions(+), 0 deletions(-) > > > > > > diff --git a/board/Marvell/gplugd/gplugd.c > > > b/board/Marvell/gplugd/gplugd.c > > > index dc7d89d..347a689 100644 > > > --- a/board/Marvell/gplugd/gplugd.c > > > +++ b/board/Marvell/gplugd/gplugd.c > > > @@ -32,6 +32,8 @@ > > > #include <mvmfp.h> > > > #include <asm/arch/mfp.h> > > > #include <asm/arch/armada100.h> > > > +#include <asm/gpio.h> > > > +#include <miiphy.h> > > > > > > DECLARE_GLOBAL_DATA_PTR; > > > > > > @@ -49,6 +51,7 @@ int board_early_init_f(void) > > > }; > > > /* configure MFP's */ > > > mfp_config(mfp_cfg); > > > + > > > > Remove this unwanted commit line > > Okay.. > > > > > > return 0; > > > } > > > > > > @@ -58,5 +61,37 @@ int board_init(void) > > > gd->bd->bi_arch_number = MACH_TYPE_SHEEVAD; > > > /* adress of boot parameters */ > > > gd->bd->bi_boot_params = armd1_sdram_base(0) + 0x100; > > > + /* Assert PHY_RST# */ > > > + gpio_direction_output(CONFIG_SYS_GPIO_PHY_RST, GPIO_CLR); > > > + udelay(10); > > > + /* Deassert PHY_RST# */ > > > + gpio_set_value(CONFIG_SYS_GPIO_PHY_RST, GPIO_SET); > > > > May you please comment why do you need to set this GPIO? > > GPIO 104 is connected to reset pin of 88E3015 PHY. and a reset is > required before initializing PHY chip.
So, good to put this as code comment :-) Regards.. Prafulla . . > > Regards, > Ajay Bhargav _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
