On 12/18/25 11:59, Quentin Schulz wrote:
> From: Quentin Schulz <[email protected]>
> 
> CMD_NET_LWIP has never existed so it cannot be right. I'm guessing the
> intent was to allow print_eth() to be called when NET_LWIP is defined
> (NET means "legacy networking stack" as opposed to NET_LWIP which is the
>  newest (and incompatible) stack). There probably was some mix-up
> between CMD_NET and NET options.
> 
> The dependency on CMD_NET seems unnecessary as it seems perfectly fine
> to run bdinfo without CMD_NET (build and run tested). So let's instead
> make the dependency on NET || NET_LWIP.
> 
> Let's sync the unit test as well.
> 
> Fixes: 95744d2527cb ("cmd: bdinfo: enable -e when CONFIG_CMD_NET_LWIP=y")
> Signed-off-by: Quentin Schulz <[email protected]>
> ---
> Changes in v2:
> - fixed unit tests for the bdinfo command,
> - Link to v1: 
> https://patch.msgid.link/[email protected]
> ---
>  cmd/bdinfo.c      | 6 +++---
>  test/cmd/bdinfo.c | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)


Reviewed-by: Jerome Forissier <[email protected]>

Thanks,
-- 
Jerome

Reply via email to