On Thu, Nov 27, 2025 at 09:21:22PM +0100, Markus Schneider-Pargmann wrote: > Hi Tom, > > On Wed Nov 26, 2025 at 9:29 PM CET, Tom Rini wrote: > > On Wed, Nov 26, 2025 at 09:25:56PM +0100, Markus Schneider-Pargmann > > (TI.com) wrote: > >> Remove symbols already present in the included file. > >> > >> Signed-off-by: Markus Schneider-Pargmann (TI.com) <[email protected]> > >> --- > >> configs/am335x_hs_evm_spi_defconfig | 3 --- > >> 1 file changed, 3 deletions(-) > >> > >> diff --git a/configs/am335x_hs_evm_spi_defconfig > >> b/configs/am335x_hs_evm_spi_defconfig > >> index > >> df009844defad13109adf2523580181b6ed6b5ca..ad1777f2bcb45bd2c8424011adc231f0e7d4ceee > >> 100644 > >> --- a/configs/am335x_hs_evm_spi_defconfig > >> +++ b/configs/am335x_hs_evm_spi_defconfig > >> @@ -1,8 +1,5 @@ > >> #include <configs/am335x_hs_evm_defconfig> > >> > >> -CONFIG_ARM=y > >> -CONFIG_ARCH_OMAP2PLUS=y > >> - > >> CONFIG_SPL_SPI_FLASH_SUPPORT=y > >> CONFIG_SPL_SPI_SUPPORT=y > > > > Did you confirm that buildman still works? That's usually the reason we > > have this kind of duplication, thanks. > > Thanks for the hint. I wasn't aware of buildman, but it looks good. > > I checked if buildman still works for it just now with this command: > > tools/buildman/buildman am335x_hs_evm_spi > > This worked. I am currently not sure if this is everything that can > break with buildman?
Well hunh. We have, historically, needed some slight amount of duplication in defconfigs that use #include in order to make sure it was still parsed right by buildman, but it seems that's no longer true. Thanks for checking. Reviewed-by: Tom Rini <[email protected]> -- Tom
signature.asc
Description: PGP signature
