Dear Wolfgang, Thanks for info, I have seen that. But i am not adding support for GPIO commands.
In reference to >> +#define GPLR(x) GPIO_REG(BANK_OFF((x) >> 5) + 0x00) >> +#define GPDR(x) GPIO_REG(BANK_OFF((x) >> 5) + 0x0c) >> +#define GPSR(x) GPIO_REG(BANK_OFF((x) >> 5) + 0x18) >> +#define GPCR(x) GPIO_REG(BANK_OFF((x) >> 5) + 0x24) >> +#define GSDR(x) GPIO_REG(BANK_OFF((x) >> 5) + 0x54) >> +#define GCDR(x) GPIO_REG(BANK_OFF((x) >> 5) + 0x60) > Please use a C struct to dsescribe the register layout. I have followed similar way of using GPIO as used by "drivers/gpio/kw_gpio.c" and defined in "include/asm/arch-kirkwood/gpio.h", so actually i am not adding GPIO support rather i wrote functions that are required by the Ethernet and other drivers. Regards, Ajay Bhargav _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot