Dear "Jason Hobbs", In message <1308853655-12407-5-git-send-email-jason.ho...@calxeda.com> you wrote: > This will be used first by the pxecfg code, but is intended to be > generic and reusable for other jobs in U-boot. > > Signed-off-by: Jason Hobbs <jason.ho...@calxeda.com> > --- > changes in v2: > - new in v2 > > common/Makefile | 1 + > common/menu.c | 338 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > include/menu.h | 40 +++++++ > 3 files changed, 379 insertions(+), 0 deletions(-) > create mode 100644 common/menu.c > create mode 100644 include/menu.h
Is this all new code, or was it copied from some other project? If so, reference would be needed. Then, we need documentation how this is going to be used. Please add a README with documentation of the interfaces and usage examples. Also, I would like to know why you didn't adapt for example the menu code from barebox - which specific advantages do you see in the code you have chosen? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I think it's a new feature. Don't tell anyone it was an accident. :-) -- Larry Wall on s/foo/bar/eieio in <10...@jpl-devvax.jpl.nasa.gov> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
