Re: [PATCH v2 09/13] phy: stm32-usbphyc: manage properly the clk identifier with CCF

[Patrick DELAUNAY]

Hi,

On 5/27/25 15:27, Patrice Chotard wrote:

From: Patrick Delaunay <patrick.delau...@foss.st.com>

Add private uclass data for "stm32-usbphyc-clk" as it is not done
by the driver model.

This clk struct is needed by CCF to save the unique id used to identify
each clock.

Signed-off-by: Patrick Delaunay <patrick.delau...@foss.st.com>
Signed-off-by: Patrice Chotard <patrice.chot...@foss.st.com>
Cc: Lukasz Majewski <lu...@denx.de>
Cc: Sean Anderson <sean...@gmail.com>
---

(no changes since v1)

  drivers/phy/phy-stm32-usbphyc.c | 19 +++++++++++++++++++
  1 file changed, 19 insertions(+)

diff --git a/drivers/phy/phy-stm32-usbphyc.c b/drivers/phy/phy-stm32-usbphyc.c
index 8d643b762f9..fcf8617ee9b 100644
--- a/drivers/phy/phy-stm32-usbphyc.c
+++ b/drivers/phy/phy-stm32-usbphyc.c
@@ -16,7 +16,9 @@
  #include <syscon.h>
  #include <usb.h>
  #include <asm/io.h>
+#include <dm/device.h>
  #include <dm/device_compat.h>
+#include <dm/device-internal.h>
  #include <dm/lists.h>
  #include <dm/of_access.h>
  #include <linux/bitfield.h>
@@ -633,6 +635,7 @@ U_BOOT_DRIVER(stm32_usb_phyc) = {

struct stm32_usbphyc_clk {

        bool enable;
+       struct clk clkp;
  };

static ulong stm32_usbphyc_clk48_get_rate(struct clk *clk)

@@ -687,9 +690,25 @@ const struct clk_ops usbphyc_clk48_ops = {
        .disable = stm32_usbphyc_clk48_disable,
  };

+int usbphyc_clk48_probe(struct udevice *dev)

+{
+       struct stm32_usbphyc_clk *priv = dev_get_priv(dev);
+
+       /* prepare clkp to correctly register clock with CCF */
+       priv->clkp.dev = dev;
+       priv->clkp.id = CLK_ID(dev, 0);
+
+       /* Store back pointer to clk from udevice */
+       /* FIXME: This is not allowed...should be allocated by driver model */

FIXME because I don't found other solution

and this code is copied on generic clocks behavior in

drivers/clk/clk.c:52:
drivers/clk/clk_fixed_rate.c:43:

+       dev_set_uclass_priv(dev, &priv->clkp);
+
+       return 0;
+}
+
  U_BOOT_DRIVER(stm32_usb_phyc_clk) = {
        .name = "stm32-usbphyc-clk",
        .id = UCLASS_CLK,
        .ops = &usbphyc_clk48_ops,
+       .probe = &usbphyc_clk48_probe,
        .priv_auto = sizeof(struct stm32_usbphyc_clk),
  };

Reviewed-by: Patrick Delaunay <patrick.delau...@foss.st.com>

Thanks
Patrick