On Fri, Apr 25, 2025 at 01:12:13AM +0000, Verdun, Jean-Marie wrote: > Hi Tom, > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #51: > new file mode 100644 > > CHECK: Avoid CamelCase: <W5500_Sn_RXMEM_SIZE> > #530: FILE: drivers/net/w5500.c:475: > + w5500_spi_write(dev, W5500_Sn_RXMEM_SIZE(0), 0x10); > > CHECK: Avoid CamelCase: <W5500_Sn_TXMEM_SIZE> > #531: FILE: drivers/net/w5500.c:476: > + w5500_spi_write(dev, W5500_Sn_TXMEM_SIZE(0), 0x10); > > CHECK: Avoid CamelCase: <W5100_Sn_MR> > #592: FILE: drivers/net/w5500.h:23: > +#define W5100_Sn_MR 0x0000 /* Sn Mode Register */ > > CHECK: Avoid CamelCase: <W5100_Sn_CR> > #593: FILE: drivers/net/w5500.h:24: > +#define W5100_Sn_CR 0x0001 /* Sn Command Register */ > > CHECK: Avoid CamelCase: <W5100_Sn_IR> > #594: FILE: drivers/net/w5500.h:25: > +#define W5100_Sn_IR 0x0002 /* Sn Interrupt Register */ > > CHECK: Avoid CamelCase: <W5100_Sn_SR> > #595: FILE: drivers/net/w5500.h:26: > +#define W5100_Sn_SR 0x0003 /* Sn Status Register */ > > CHECK: Avoid CamelCase: <W5100_Sn_TX_FSR> > #596: FILE: drivers/net/w5500.h:27: > +#define W5100_Sn_TX_FSR 0x0020 /* Sn Transmit free memory size */ > > CHECK: Avoid CamelCase: <W5100_Sn_TX_RD> > #597: FILE: drivers/net/w5500.h:28: > +#define W5100_Sn_TX_RD 0x0022 /* Sn Transmit memory read pointer */ > > CHECK: Avoid CamelCase: <W5100_Sn_TX_WR> > #598: FILE: drivers/net/w5500.h:29: > +#define W5100_Sn_TX_WR 0x0024 /* Sn Transmit memory write pointer */ > > CHECK: Avoid CamelCase: <W5100_Sn_RX_RSR> > #599: FILE: drivers/net/w5500.h:30: > +#define W5100_Sn_RX_RSR 0x0026 /* Sn Receive free memory size */ > > CHECK: Avoid CamelCase: <W5100_Sn_RX_RD> > #600: FILE: drivers/net/w5500.h:31: > +#define W5100_Sn_RX_RD 0x0028 /* Sn Receive memory read pointer */ > > This is the errors message I am getting with checkpatch.pl from uboot repo. > All of these Macros/define are defined that way inside the linux kernel. Do > you want me to adapt for uboot or is that something acceptable ?
This part is fine then, thanks for explaining. > I didn’t added myself into the net MAINTAINER section as others dev > didn’t did it. Is that something I need to fix ? It would be good to list yourself somewhere for this, yes. Thanks! -- Tom
signature.asc
Description: PGP signature
