Hi Tom, WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644
CHECK: Avoid CamelCase: <W5500_Sn_RXMEM_SIZE> #530: FILE: drivers/net/w5500.c:475: + w5500_spi_write(dev, W5500_Sn_RXMEM_SIZE(0), 0x10); CHECK: Avoid CamelCase: <W5500_Sn_TXMEM_SIZE> #531: FILE: drivers/net/w5500.c:476: + w5500_spi_write(dev, W5500_Sn_TXMEM_SIZE(0), 0x10); CHECK: Avoid CamelCase: <W5100_Sn_MR> #592: FILE: drivers/net/w5500.h:23: +#define W5100_Sn_MR 0x0000 /* Sn Mode Register */ CHECK: Avoid CamelCase: <W5100_Sn_CR> #593: FILE: drivers/net/w5500.h:24: +#define W5100_Sn_CR 0x0001 /* Sn Command Register */ CHECK: Avoid CamelCase: <W5100_Sn_IR> #594: FILE: drivers/net/w5500.h:25: +#define W5100_Sn_IR 0x0002 /* Sn Interrupt Register */ CHECK: Avoid CamelCase: <W5100_Sn_SR> #595: FILE: drivers/net/w5500.h:26: +#define W5100_Sn_SR 0x0003 /* Sn Status Register */ CHECK: Avoid CamelCase: <W5100_Sn_TX_FSR> #596: FILE: drivers/net/w5500.h:27: +#define W5100_Sn_TX_FSR 0x0020 /* Sn Transmit free memory size */ CHECK: Avoid CamelCase: <W5100_Sn_TX_RD> #597: FILE: drivers/net/w5500.h:28: +#define W5100_Sn_TX_RD 0x0022 /* Sn Transmit memory read pointer */ CHECK: Avoid CamelCase: <W5100_Sn_TX_WR> #598: FILE: drivers/net/w5500.h:29: +#define W5100_Sn_TX_WR 0x0024 /* Sn Transmit memory write pointer */ CHECK: Avoid CamelCase: <W5100_Sn_RX_RSR> #599: FILE: drivers/net/w5500.h:30: +#define W5100_Sn_RX_RSR 0x0026 /* Sn Receive free memory size */ CHECK: Avoid CamelCase: <W5100_Sn_RX_RD> #600: FILE: drivers/net/w5500.h:31: +#define W5100_Sn_RX_RD 0x0028 /* Sn Receive memory read pointer */ This is the errors message I am getting with checkpatch.pl from uboot repo. All of these Macros/define are defined that way inside the linux kernel. Do you want me to adapt for uboot or is that something acceptable ? I assumed it was acceptable, and sent a v2 of the patch. I can make a v3 without any issues if needed. What might be your guidance in such case ? Everything in uppercase ? I didn’t added myself into the net MAINTAINER section as others dev didn’t did it. Is that something I need to fix ? Jean-Marie On 4/24/25, 4:55 PM, "Tom Rini" <tr...@konsulko.com> wrote: On Thu, Apr 24, 2025 at 09:43:35PM +0000, ver...@hpe.com<mailto:ver...@hpe.com> wrote: > From: Jean-Marie Verdun <ver...@hpe.com<mailto:ver...@hpe.com>> > > Add support for the Wiznet W5500 spi to ethernet controller > > Signed-off-by: Jean-Marie Verdun <ver...@hpe.com<mailto:ver...@hpe.com>> > --- > drivers/net/Kconfig | 54 ++--- > drivers/net/Makefile | 7 +- > drivers/net/w5500.c | 508 +++++++++++++++++++++++++++++++++++++++++++ > drivers/net/w5500.h | 135 ++++++++++++ > 4 files changed, 662 insertions(+), 42 deletions(-) > create mode 100644 drivers/net/w5500.c > create mode 100644 drivers/net/w5500.h There are spacing problems in the Kconfig file as well as a number of unrelated and incorrect changes. The Makefile also has removing of other drivers in it. Finally, the driver itself has checkpatch.pl issues to resolve. Please look in to all of this for v2, thanks. -- Tom
