On Mon, Apr 28, 2025 at 11:44:06AM +0530, Anshul Dalal wrote:
> On Fri Apr 25, 2025 at 11:35 PM IST, Tom Rini wrote:
> > On Fri, Apr 25, 2025 at 08:26:40PM +0530, Anshul Dalal wrote:
> >> This patch adds user documentation for falcon boot for am62 platforms.
> >> The main section is added to am62x_sk.rst and other documents just
> >> include the section. Steps to build falcon support, usage and the
> >> modified R5 memory map have been documented.
> >>
> >> Two svg images have also been added for reference, one for the modified
> >> tispl_falcon.bin and other for the falcon specific fitImage format.
> >>
> >> Signed-off-by: Anshul Dalal <ansh...@ti.com>
> >> ---
> >> doc/board/ti/am62ax_sk.rst | 7 +
> >> doc/board/ti/am62px_sk.rst | 7 +
> >> doc/board/ti/am62x_sk.rst | 248 ++++++++++++++++++
> >> doc/board/ti/img/fitImage_falcon.svg | Bin 0 -> 5511 bytes
> >> .../ti/img/tifsstub_dm_tispl_falcon.bin.svg | Bin 0 -> 9466 bytes
> >
> > I suspect these SVGs suffer from the same feedback that was given to
> > some of Neha's recently, which is that instead of being good line SVGs
> > they're embedding other graphical blobs. Please check and rework these
> > so they show up as just good xml files on the inside and not binary,
> > thanks.
>
> Actually the issue seems to be with the .gitattributes file, after the
> commit 284ef1bbcefc ("doc: memory: Add documentation for system RAM")
> all svgs are treated as binaries by git by default. The content of the
> SVGs I posted is just regular xml but git still treats it as a binary
> blob.
>
> For now, I'll send the next patch set with the svgs added as text files
> instead.Oh. Lets just fix the gitattribute file then, thanks! -- Tom
signature.asc
Description: PGP signature
