On Mon, Apr 7, 2025 at 3:39 AM Eugen Hristev <eugen.hris...@linaro.org> wrote:
> I am not convinced. > The purpose of this early UART would be to get output *before* the DM > code would enable clocks, pins, etc, for exactly that purpose, early > debug output. > So to remove all this and make the initialization rely on the SPL DM > code would defeat the purpose. Ok, but if we have CONFIG_DEBUG_UART enabled, shouldn't we then disable CONFIG_SPL_SERIAL? The change below fixes the serial garbage shown in SPL: --- a/configs/sama5d27_wlsom1_ek_mmc_defconfig +++ b/configs/sama5d27_wlsom1_ek_mmc_defconfig @@ -16,7 +16,6 @@ CONFIG_OF_LIBFDT_OVERLAY=y CONFIG_DM_RESET=y CONFIG_SYS_MONITOR_LEN=524288 CONFIG_SPL_MMC=y -CONFIG_SPL_SERIAL=y CONFIG_SPL_DRIVERS_MISC=y CONFIG_SPL_STACK=0x218000 CONFIG_SPL_TEXT_BASE=0x200000 I suspect CONFIG_DEBUG_UART and CONFIG_SPL_SERIAL conflict with each other. Is the change above acceptable? If not, what would you suggest?
