On Sat, Apr 5, 2025, 08:58 Heinrich Schuchardt < heinrich.schucha...@canonical.com> wrote:
> It has been reported that memory corruption can occurred because network > packages where received after EXIT_BOOT_SERVICES. See the thread > starting at [1]. > > We try to remove all drivers when EXIT_BOOT_SERVICES is called. But > > * Some network drivers don't call their own stop method when removed. > * Some network drivers don't have a remove method. > * Some devices have CONFIG_DM_DEVICE_REMOVE=n. > > Let's call eth_halt() in EXIT_BOOT_SERVICES explicitly. > Thanks Heinrich Reviewed-by: Ilias Apalodimas <ilias.apalodi...@linaro.org> > > [1] > > https://lore.kernel.org/all/c101b675-eee6-44cb-8a44-83f72182f...@kohlschutter.com/ > > Cc: Michael Brown <mc...@ipxe.org> > Reported-by: Christian Kohlschütter <christ...@kohlschutter.com> > Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com> > --- > lib/efi_loader/efi_boottime.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c > index 5164cb15986..eaa6464fa39 100644 > --- a/lib/efi_loader/efi_boottime.c > +++ b/lib/efi_loader/efi_boottime.c > @@ -15,6 +15,7 @@ > #include <irq_func.h> > #include <log.h> > #include <malloc.h> > +#include <net-common.h> > #include <pe.h> > #include <time.h> > #include <u-boot/crc.h> > @@ -2235,6 +2236,8 @@ static efi_status_t EFIAPI > efi_exit_boot_services(efi_handle_t image_handle, > bootm_disable_interrupts(); > if (IS_ENABLED(CONFIG_USB_DEVICE)) > udc_disconnect(); > + if (IS_ENABLED(CONFIG_DM_ETH)) > + eth_halt(); > board_quiesce_devices(); > dm_remove_devices_active(); > } > -- > 2.48.1 > >
